Skip to content

Added doctests to bucket sort #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 17, 2020
Merged

Added doctests to bucket sort #2079

merged 8 commits into from
Jun 17, 2020

Conversation

l3str4nge
Copy link
Member

Describe your change:

Added missing doctests.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@l3str4nge l3str4nge requested review from cclauss and poyea June 15, 2020 13:49
poyea
poyea approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@poyea poyea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the tests!

cclauss
cclauss reviewed Jun 16, 2020
View reviewed changes
sorts/bucket_sort.py Outdated
number of buckets.

Time Complexity of Solution:
Worst case scenario occurs when all the elements are placed in a single bucket. The overall performance
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap lines to 88 characters max.

@TravisBuddy
Copy link

Travis tests have failed

Hey @mateuszz0000,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 75775280-af9a-11ea-aad4-a340821c2822

@Bhavik-Jikadara
Copy link

What is it

@cclauss
Copy link
Member

cclauss commented Jun 16, 2020

Is it a problem that the algorithm uses the builtin sorted() function?

@l3str4nge
Copy link
Member Author

@cclauss should we merge it?

cclauss
cclauss reviewed Jun 17, 2020
View reviewed changes
sorts/bucket_sort.py Outdated
@@ -1,5 +1,3 @@
#!/usr/bin/env python3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the shebang line? https://en.wikipedia.org/wiki/Shebang_(Unix)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad.

cclauss
cclauss approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work here!

@l3str4nge l3str4nge merged commit d7a75da into TheAlgorithms:master Jun 17, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@l3str4nge @cclauss @stokhos
Added doctests to bucket sort (TheAlgorithms#2079)
efdaf5a 
* Added doctests to bucket sort

* Missing typehint

* Wrap long lines

* updating DIRECTORY.md

* Update bucket_sort.py

* updating DIRECTORY.md

* Update bucket_sort.py

Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: github-actions <${GITHUB_ACTOR}@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cclauss cclauss cclauss approved these changes

@poyea poyea poyea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@l3str4nge @TravisBuddy @Bhavik-Jikadara @cclauss @poyea